NSAmelchev commented on a change in pull request #8240:
URL: https://github.com/apache/ignite/pull/8240#discussion_r486876380
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
##########
@@ -412,8 +413,16 @@ private void registerSystemView() {
try {
List<MetastorageView> data = new ArrayList<>();
- metaStorage.iterate("", (key, val) ->
- data.add(new MetastorageView(key,
IgniteUtils.toStringSafe(val))), true);
+ metaStorage.iterate("", (key, valBytes) -> {
+ try {
+ Serializable val =
metaStorage.marshaller().unmarshal((byte[])valBytes, U.gridClassLoader());
+
+ data.add(new MetastorageView(key,
IgniteUtils.toStringSafe(val)));
+ }
+ catch (IgniteCheckedException ignored) {
+ data.add(new MetastorageView(key, null));
Review comment:
I suggest to add to javadoc info about that `null` value is can be raw
data.
As alternative way show something like `[Raw data]` instead of `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
