timoninmaxim commented on a change in pull request #8206:
URL: https://github.com/apache/ignite/pull/8206#discussion_r488665705
##########
File path:
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
##########
@@ -115,18 +125,35 @@
/** Reconnect throttling retries. See {@code reconnectThrottlingPeriod}. */
private int reconnectThrottlingRetries = 3;
+ /** Retry limit. */
+ private int retryLimit = 0;
+
/**
* @return Host addresses.
*/
public String[] getAddresses() {
- return addrs;
+ return Optional.ofNullable(addrFinder)
Review comment:
fixed.
##########
File path:
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
##########
@@ -115,18 +125,35 @@
/** Reconnect throttling retries. See {@code reconnectThrottlingPeriod}. */
private int reconnectThrottlingRetries = 3;
+ /** Retry limit. */
+ private int retryLimit = 0;
+
/**
* @return Host addresses.
*/
public String[] getAddresses() {
- return addrs;
+ return Optional.ofNullable(addrFinder)
+ .map(Supplier::get)
+ .orElse(addrs);
}
/**
* @param addrs Host addresses.
*/
public ClientConfiguration setAddresses(String... addrs) {
- this.addrs = addrs;
+ if (addrs != null) {
Review comment:
fixed.
##########
File path:
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java
##########
@@ -115,18 +125,35 @@
/** Reconnect throttling retries. See {@code reconnectThrottlingPeriod}. */
private int reconnectThrottlingRetries = 3;
+ /** Retry limit. */
+ private int retryLimit = 0;
+
/**
* @return Host addresses.
*/
public String[] getAddresses() {
- return addrs;
+ return Optional.ofNullable(addrFinder)
+ .map(Supplier::get)
+ .orElse(addrs);
}
/**
* @param addrs Host addresses.
*/
public ClientConfiguration setAddresses(String... addrs) {
- this.addrs = addrs;
+ if (addrs != null) {
+ this.addrs = Arrays.copyOf(addrs, addrs.length);
+ addrFinder = () -> this.addrs;
+ }
+
+ return this;
+ }
+
+ /**
+ * @param finder function that finds node addresses
+ */
+ public ClientConfiguration setAddressesFinder(Supplier<String[]> finder) {
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
