ascherbakoff commented on a change in pull request #8235:
URL: https://github.com/apache/ignite/pull/8235#discussion_r490031762
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/task/GridTaskProcessor.java
##########
@@ -1138,14 +1138,15 @@ public void processJobExecuteResponse(UUID nodeId,
GridJobExecuteResponse msg) {
lock.readLock();
try {
+ GridTaskWorker<?, ?> task = tasks.get(msg.getSessionId());
+
if (stopping && !waiting) {
- U.warn(log, "Received job execution response while stopping
grid (will ignore): " + msg);
+ U.warn(log, "Received job execution response while stopping
grid (will ignore): " + msg
+ + (task != null && task.getSession() != null ? (", " +
task.getSession().getTaskName()) : ""));
Review comment:
The similar code block repeats 5 times. It should be refactored to
separate method, like tryResolveTaskName(sesId)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
