agura commented on a change in pull request #8135:
URL: https://github.com/apache/ignite/pull/8135#discussion_r490202091
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/GridSystemViewManager.java
##########
@@ -75,7 +82,26 @@
* @param ctx Kernal context.
*/
public GridSystemViewManager(GridKernalContext ctx) {
- super(ctx, ctx.config().getSystemViewExporterSpi());
+ super(ctx, ((Supplier<SystemViewExporterSpi[]>)() -> {
+ SystemViewExporterSpi[] spi =
ctx.config().getSystemViewExporterSpi();
+
+ if (!IgniteComponentType.INDEXING.inClassPath())
+ return spi;
+
+ SystemViewExporterSpi[] spiWithSql = new SystemViewExporterSpi[spi
!= null ? spi.length + 1 : 1];
Review comment:
It's definitely redundant deu to a package privacy. I told about naming
only. Please revert this check and merge.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/GridSystemViewManager.java
##########
@@ -75,7 +82,26 @@
* @param ctx Kernal context.
*/
public GridSystemViewManager(GridKernalContext ctx) {
- super(ctx, ctx.config().getSystemViewExporterSpi());
+ super(ctx, ((Supplier<SystemViewExporterSpi[]>)() -> {
+ SystemViewExporterSpi[] spi =
ctx.config().getSystemViewExporterSpi();
+
+ if (!IgniteComponentType.INDEXING.inClassPath())
+ return spi;
+
+ SystemViewExporterSpi[] spiWithSql = new SystemViewExporterSpi[spi
!= null ? spi.length + 1 : 1];
Review comment:
It's definitely redundant due to a package privacy. I told about naming
only. Please revert this check and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
