nizhikov commented on a change in pull request #8249: URL: https://github.com/apache/ignite/pull/8249#discussion_r492590310
########## File path: modules/core/src/main/java/org/apache/ignite/internal/visor/systemview/VisorSystemViewTaskResult.java ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.visor.systemview; + +import java.io.IOException; +import java.io.ObjectInput; +import java.io.ObjectOutput; +import java.util.ArrayList; +import java.util.List; +import org.apache.ignite.internal.dto.IgniteDataTransferObject; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.internal.visor.systemview.VisorSystemViewTask.SimpleAttributeType; + +/** + * Reperesents result of {@link VisorSystemViewTask}. + */ +public class VisorSystemViewTaskResult extends IgniteDataTransferObject { + /** */ + private static final long serialVersionUID = 0L; + + /** Attribute values for each row of the system view. */ + private List<List<?>> rows; + + /** Names of the system view attributes. */ + private List<String> attrs; + + /** Types of the systen view attributes. */ + List<SimpleAttributeType> types; + + /** + * Default constructor. + */ + public VisorSystemViewTaskResult() { + // No-op. + } + + /** + * @param attrs Names of system view attributes. + * @param rows Attribute values for each row of the system view. + */ + public VisorSystemViewTaskResult(List<String> attrs, List<SimpleAttributeType> types, List<List<?>> rows) { + this.attrs = attrs; + this.types = types; + this.rows = rows; + } + + /** + * @return Names of the system view attributes. Review comment: Let's make this and similar comment one liner. ########## File path: modules/core/src/main/java/org/apache/ignite/internal/visor/systemview/VisorSystemViewTaskResult.java ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.visor.systemview; + +import java.io.IOException; +import java.io.ObjectInput; +import java.io.ObjectOutput; +import java.util.ArrayList; +import java.util.List; +import org.apache.ignite.internal.dto.IgniteDataTransferObject; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.apache.ignite.internal.visor.systemview.VisorSystemViewTask.SimpleAttributeType; + +/** + * Reperesents result of {@link VisorSystemViewTask}. + */ +public class VisorSystemViewTaskResult extends IgniteDataTransferObject { + /** */ + private static final long serialVersionUID = 0L; + + /** Attribute values for each row of the system view. */ + private List<List<?>> rows; + + /** Names of the system view attributes. */ + private List<String> attrs; + + /** Types of the systen view attributes. */ + List<SimpleAttributeType> types; + + /** + * Default constructor. + */ + public VisorSystemViewTaskResult() { + // No-op. + } + + /** + * @param attrs Names of system view attributes. + * @param rows Attribute values for each row of the system view. + */ + public VisorSystemViewTaskResult(List<String> attrs, List<SimpleAttributeType> types, List<List<?>> rows) { + this.attrs = attrs; + this.types = types; + this.rows = rows; + } + + /** + * @return Names of the system view attributes. + */ + public List<String> systemViewAttributes() { + return attrs; + } + + /** + * @return Attribute values for each row of the system view. + */ + public List<List<?>> systemViewContent() { + return rows; + } + + /** + * @return Types of the system view attributes. + */ + public List<SimpleAttributeType> systemViewAttributeTypes() { + return types; + } + + /** + * {@inheritDoc} Review comment: Please, make it one line comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
