timoninmaxim commented on a change in pull request #8206:
URL: https://github.com/apache/ignite/pull/8206#discussion_r493495522
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java
##########
@@ -461,9 +418,8 @@ private void initAllChannelsAsync() {
* @param ch Channel.
*/
private void onTopologyChanged(ClientChannel ch) {
- if (partitionAwarenessEnabled &&
affinityCtx.updateLastTopologyVersion(ch.serverTopologyVersion(),
- ch.serverNodeId()))
- initAllChannelsAsync();
+ if (affinityCtx.updateLastTopologyVersion(ch.serverTopologyVersion(),
ch.serverNodeId()))
+ channelsInit(true);
Review comment:
> we can do it sync in sending thread on channel failure and if we
detect topology change before
It can be wrong. Topology change can be triggered by joining node, so
channel failure may never occur. I'll make async initialization in any case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
