timoninmaxim commented on a change in pull request #8267:
URL: https://github.com/apache/ignite/pull/8267#discussion_r494180548
##########
File path: modules/ducktests/tests/ignitetest/services/ignite.py
##########
@@ -46,13 +46,40 @@ def __init__(self, context, config, num_nodes,
jvm_opts=None, modules=None):
# pylint: disable=W0221
def start(self, timeout_sec=180):
+ self._rotate_log()
+
super().start()
self.logger.info("Waiting for Ignite(s) to start...")
for node in self.nodes:
self.await_node_started(node, timeout_sec)
+ def run(self, timeout_sec=180):
Review comment:
Don't like it. Ducktape Service provides `start` method and it do some
additional work than `start_node`. It is misleading which method (run or start)
to invoke. As you add rotate log to start, can you remove run method at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
