timoninmaxim commented on a change in pull request #8206:
URL: https://github.com/apache/ignite/pull/8206#discussion_r494969192
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java
##########
@@ -461,9 +418,8 @@ private void initAllChannelsAsync() {
* @param ch Channel.
*/
private void onTopologyChanged(ClientChannel ch) {
- if (partitionAwarenessEnabled &&
affinityCtx.updateLastTopologyVersion(ch.serverTopologyVersion(),
- ch.serverNodeId()))
- initAllChannelsAsync();
+ if (affinityCtx.updateLastTopologyVersion(ch.serverTopologyVersion(),
ch.serverNodeId()))
+ channelsInit(true);
Review comment:
Fair. Fixed it. Change signature of `initChannelHolders`, now it's not
void but returns boolean (flag of interruption). Otherwise for disabled
awareness and continuous topology events there would be a chances for
StackOverflow, as channel failure trigger recursively `applyOnDefaultChannel`
to enable default channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
