ivandasch commented on a change in pull request #8267: URL: https://github.com/apache/ignite/pull/8267#discussion_r494127689
########## File path: modules/ducktests/tests/ignitetest/tests/snapshot_test.py ########## @@ -0,0 +1,162 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +""" +Module contains discovery tests. +""" + +import time +import re + +from ducktape.mark.resource import cluster + +from ignitetest.services.ignite import IgniteService +from ignitetest.services.ignite_app import IgniteApplicationService +from ignitetest.services.utils.control_utility import ControlUtility +from ignitetest.services.utils.ignite_configuration import IgniteConfiguration, DataStorageConfiguration +from ignitetest.services.utils.ignite_configuration.data_storage import DataRegionConfiguration +from ignitetest.utils import ignite_versions +from ignitetest.utils.ignite_test import IgniteTest +from ignitetest.utils.version import DEV_BRANCH, IgniteVersion + + +# pylint: disable=W0223 +class SnapshotTest(IgniteTest): + """ + Test Snapshot. + """ + NUM_NODES = 4 + + SNAPSHOT_NAME = "test_snap" + + @cluster(num_nodes=NUM_NODES) + @ignite_versions(str(DEV_BRANCH)) + def snapshot_test(self, ignite_version): + """ + Test Snapshot. + 1. Start of ignite cluster. + 2. Activate cluster. + 3. Load. + 4. Idle verify dump1. + 5. Snapshot. + 6. Load. + 7. Idle verify dump2. + 8. Сhecking that dump1 and dump2 are differentю + 9. Stop ignite and replace db from snapshot + 10. Run ignite cluster. + 11. Idle verify dump3. + 12. Checking the equality of dump1 and dump3. + """ + data_cfg = DataStorageConfiguration(default=DataRegionConfiguration(persistent=True)) + + ignite_config = IgniteConfiguration( + version=IgniteVersion(ignite_version), + data_storage=data_cfg, + ) + + service = IgniteService(self.test_context, ignite_config, num_nodes=self.NUM_NODES - 1) + service.start() + + control_utility = ControlUtility(service, self.test_context) + control_utility.activate() + + client_config = ignite_config._replace(client_mode=True, data_storage=None) + + streamer = IgniteApplicationService( + self.test_context, + client_config, + java_class_name="org.apache.ignite.internal.ducktest.tests.UuidStreamerApplication", + params={"cacheName": "test-cache"}) + + load(streamer) + + node = service.nodes[0] + + check_idle_verify(control_utility) + check_validate_indexes(control_utility) + dump_1 = get_dump_path(control_utility, node) + + self.logger.warn("Path to dump_1=" + dump_1) + + data = control_utility.snapshot_create(self.SNAPSHOT_NAME) + + self.logger.warn(data) + + load(streamer) + + dump_2 = get_dump_path(control_utility, node) + + self.logger.warn("Path to dump_2=" + dump_2) + + diff = node.account.ssh_output(f'diff {dump_1} {dump_2}', allow_fail=True) + assert len(diff) != 0, diff + + service.rename_db(new_db_name='old_db') + service.copy_snap_to_db(self.SNAPSHOT_NAME) + + service.run() + + control_utility.activate() + + check_idle_verify(control_utility) + check_validate_indexes(control_utility) + dump_3 = get_dump_path(control_utility, node) + + self.logger.warn("Path to dump_3=" + dump_2) + + diff = node.account.ssh_output(f'diff {dump_1} {dump_3}', allow_fail=True) + assert len(diff) == 0, diff Review comment: No, this is because snapshot is restored ########## File path: modules/ducktests/tests/ignitetest/utils/ignite_test.py ########## @@ -40,3 +44,45 @@ def monotonic(): so that only the difference between the results of consecutive calls is valid. """ return monotonic() + + def copy_ignite_root_dir(self): + """ + Copying root directory from service nodes to the results directory. + """ + for service in self.test_context.services: + if not isinstance(service, IgniteService): + self.logger.debug("Won't collect service workdir from %s." % service.service_id) + continue + + if service.config.data_storage and service.config.data_storage.default.persistent: + # Try to copy the root directory + self.logger.debug("Copying persistence dir...") + try: + for node in service.nodes: + dest = os.path.join( + TestContext.results_dir(self.test_context, self.test_context.test_index), + service.service_id, node.account.hostname) + self.logger.debug("Dest dir " + dest) + if not os.path.isdir(dest): + mkdir_p(dest) + + tgz_root = '%s.tgz' % PersistenceAware.PERSISTENT_ROOT + + node.account.ssh(compress_cmd(PersistenceAware.PERSISTENT_ROOT, tgz_root)) + node.account.copy_from(tgz_root, dest) + except Exception as ex: Review comment: Please, inline warning W0703 and remove it from class comment. ########## File path: modules/ducktests/tests/ignitetest/services/ignite.py ########## @@ -46,13 +46,40 @@ def __init__(self, context, config, num_nodes, jvm_opts=None, modules=None): # pylint: disable=W0221 def start(self, timeout_sec=180): + self._rotate_log() + super().start() self.logger.info("Waiting for Ignite(s) to start...") for node in self.nodes: self.await_node_started(node, timeout_sec) + def run(self, timeout_sec=180): Review comment: Unfortunatelly, ducktape allows start node only with cleaning. We should add smth like restart and comment that this should be rewrittten after appropriate change in ducktape codebase will be merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
