dmagda commented on a change in pull request #8279:
URL: https://github.com/apache/ignite/pull/8279#discussion_r496216898
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -168,6 +168,35 @@ This view exposes information about currently running
compute tasks started by a
|USER_VERSION | string | Task user version
|===
+== JOBS
Review comment:
I would clarify what type of jobs we are talking "JOBS" => "Compute Jobs"
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -168,6 +168,35 @@ This view exposes information about currently running
compute tasks started by a
|USER_VERSION | string | Task user version
|===
+== JOBS
+
+This view exposes information about currently running compute job started on a
node.
Review comment:
"This system view shows a list of compute jobs started by a node as part
of a compute task. To view the status of the compute task refer to the TASKS
system view." - how about rephrasing this way?
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -168,6 +168,35 @@ This view exposes information about currently running
compute tasks started by a
|USER_VERSION | string | Task user version
|===
+== JOBS
+
+This view exposes information about currently running compute job started on a
node.
+In the Ignite, Job defines part(step) of the compute task
+
+[{table_opts}]
+|===
+|NAME | TYPE | DESCRIPTION
+|ID | UUID | Job ID
+|SESSION_ID | UUID | Session ID. Note, `SESSION_ID` equal to
`TASKS.SESSION_ID` for the jobs that belongs to the specific task
Review comment:
"belongs" => "belong"
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -337,23 +366,6 @@ This view exposes information about currently running scan
queries.
|===
-== SQL_QUERIES_HISTORY
Review comment:
Did we remove this view or replaced it? Or did you remove this
accidentally?
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -168,6 +168,35 @@ This view exposes information about currently running
compute tasks started by a
|USER_VERSION | string | Task user version
|===
+== JOBS
+
+This view exposes information about currently running compute job started on a
node.
+In the Ignite, Job defines part(step) of the compute task
+
+[{table_opts}]
+|===
+|NAME | TYPE | DESCRIPTION
+|ID | UUID | Job ID
+|SESSION_ID | UUID | Session ID. Note, `SESSION_ID` equal to
`TASKS.SESSION_ID` for the jobs that belongs to the specific task
+|ORIGIN_NODE_ID | UUID | Originating node id
+|TASK_NAME | string | Name of the task
+|TASK_CLASSNAME | string | Class name of the task
+|AFFINITY_CACHE_IDS | string | Affinity cache ids
+|AFFINITY_PARTITION_ID | int | Partition id
+|CREATE_TIME | long | Create time
+|START_TIME | long | Start time
+|FINISH_TIME | long | Finish time
+|EXECUTOR_NAME | string | Name of the executor for task
+|IS_FINISHING | boolean | True if job finishing
+|IS_INTERNAL | boolean | True if job internal
+|IS_STARTED | boolean | True if job started
+|IS_TIMEDOUT | boolean | True if job timed out
+|STATE | string | Possible values: +
+`ACTIVE` - scheduled for execution. +
Review comment:
Is the job being executed right now or has been just scheduled but not
running yet? It's unclear. The name of the parameters suggests that the job is
executing right now while the description talks about scheduling.
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -168,6 +168,35 @@ This view exposes information about currently running
compute tasks started by a
|USER_VERSION | string | Task user version
|===
+== JOBS
+
+This view exposes information about currently running compute job started on a
node.
+In the Ignite, Job defines part(step) of the compute task
+
+[{table_opts}]
+|===
+|NAME | TYPE | DESCRIPTION
+|ID | UUID | Job ID
+|SESSION_ID | UUID | Session ID. Note, `SESSION_ID` equal to
`TASKS.SESSION_ID` for the jobs that belongs to the specific task
+|ORIGIN_NODE_ID | UUID | Originating node id
+|TASK_NAME | string | Name of the task
+|TASK_CLASSNAME | string | Class name of the task
+|AFFINITY_CACHE_IDS | string | Affinity cache ids
+|AFFINITY_PARTITION_ID | int | Partition id
+|CREATE_TIME | long | Create time
+|START_TIME | long | Start time
+|FINISH_TIME | long | Finish time
+|EXECUTOR_NAME | string | Name of the executor for task
+|IS_FINISHING | boolean | True if job finishing
+|IS_INTERNAL | boolean | True if job internal
+|IS_STARTED | boolean | True if job started
+|IS_TIMEDOUT | boolean | True if job timed out
+|STATE | string | Possible values: +
+`ACTIVE` - scheduled for execution. +
+`PASSIVE` - passivated before execution. Please, see `CollisionSPI`. +
Review comment:
I would say "The job is added to the execution queue". Is it correct?
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -168,6 +168,35 @@ This view exposes information about currently running
compute tasks started by a
|USER_VERSION | string | Task user version
|===
+== JOBS
+
+This view exposes information about currently running compute job started on a
node.
+In the Ignite, Job defines part(step) of the compute task
+
+[{table_opts}]
+|===
+|NAME | TYPE | DESCRIPTION
+|ID | UUID | Job ID
+|SESSION_ID | UUID | Session ID. Note, `SESSION_ID` equal to
`TASKS.SESSION_ID` for the jobs that belongs to the specific task
+|ORIGIN_NODE_ID | UUID | Originating node id
Review comment:
Is this the id of the 1) node that started the job or the 2) node where
the job will be executed?
If #1 then say "The id of the node that started the job", otherwise "The id
of the node where the job is being executed"
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -168,6 +168,35 @@ This view exposes information about currently running
compute tasks started by a
|USER_VERSION | string | Task user version
|===
+== JOBS
+
+This view exposes information about currently running compute job started on a
node.
+In the Ignite, Job defines part(step) of the compute task
+
+[{table_opts}]
+|===
+|NAME | TYPE | DESCRIPTION
+|ID | UUID | Job ID
+|SESSION_ID | UUID | Session ID. Note, `SESSION_ID` equal to
`TASKS.SESSION_ID` for the jobs that belongs to the specific task
+|ORIGIN_NODE_ID | UUID | Originating node id
+|TASK_NAME | string | Name of the task
+|TASK_CLASSNAME | string | Class name of the task
+|AFFINITY_CACHE_IDS | string | Affinity cache ids
Review comment:
Can we clarify the purpose of these AFFINITY parameters? Do the
parameters list all caches and partitions the job is mapped to? What will be
reported in these parameters if the job is broadcasted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
