ivandasch commented on a change in pull request #8211:
URL: https://github.com/apache/ignite/pull/8211#discussion_r498850482
##########
File path: modules/ducktests/tests/ignitetest/services/zk/zookeeper.py
##########
@@ -27,8 +27,9 @@ class ZookeeperSettings:
"""
Settings for zookeeper quorum nodes.
"""
- def __init__(self, tick_time=1000, init_limit=10, sync_limit=5,
client_port=2181):
- self.tick_time = tick_time
+ def __init__(self, min_session_timeout=2000, init_limit=10, sync_limit=5,
client_port=2181):
+ self.tick_time = min_session_timeout // 2
Review comment:
I suppose that it's better leave tick time and add assertion that
min_session_timeout is at least twice as tick_time.
It's ok to pass tickTime as 1000 ms, and set minSessionTimeout as 3000 ms
By default, let them be 1000 and 2000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
