ptupitsyn commented on a change in pull request #8206: URL: https://github.com/apache/ignite/pull/8206#discussion_r501217118
########## File path: modules/core/src/main/java/org/apache/ignite/client/ClientAddressFinder.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.client; + +/** + * This interface provides a list of addresses of Ignite server nodes within a cluster. Thin client uses the list to + * route user requests. There are cases when the list is not static, for example in cloud environment. In such cases + * addresses of nodes and/or number of server nodes can change. Implementation of this interface should handle these. + * + * Ignite waites for a topology change to trigger {@link #getAddresses()}. There are two modes of how soon Ignite calls + * it, lazy and eager, depending on whether the partition awareness feature is enabled. If the feature is enabled then + * Ignite calls the method for every topology change. Otherwise Ignite uses previous addresses until a first failure. + * + * {@link org.apache.ignite.configuration.ClientConfiguration#setPartitionAwarenessEnabled(boolean)} + * {@link org.apache.ignite.configuration.ClientConfiguration#setAddressesFinder(ClientAddressFinder)} + */ +public interface ClientAddressFinder { + /** + * Get addresses of Ignite server nodes within a cluster. An address can be IPv4 address or hostname, with or Review comment: I thought we support IPv6? Is there any reason not to? ########## File path: modules/indexing/pom.xml ########## @@ -133,6 +133,14 @@ <version>${guava.version}</version> <scope>test</scope> </dependency> + + <dependency> Review comment: Are you sure? It compiles and runs on my machine without this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
