ibessonov commented on a change in pull request #7941:
URL: https://github.com/apache/ignite/pull/7941#discussion_r501755629
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/io/PageIO.java
##########
@@ -258,6 +258,9 @@
/** */
public static final short T_MARKER_PAGE = 33;
+ /** */
+ public static final short T_INDEX_META = 34;
Review comment:
I suggest class PageIndexIO being just T_META with version 2, see no
problems with this approach. Just as now, two different classes will add two
independent sets of new integers, that's fine. The only thing that's changed is
that PageIndexIO will have the same type as its base class.
Types should be immutable while pages are alive. This saves us from a lot of
troubles, I wouldn't abandon this tradition. That's exactly what versions are
for.
BTW your current code has bugs, you don't mark meta page as dirty in
"getOrAllocateCacheMetas" while upgrading, please fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
