sk0x50 commented on a change in pull request #7941:
URL: https://github.com/apache/ignite/pull/7941#discussion_r503348265
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/pagemem/wal/record/EncryptedRecord.java
##########
@@ -43,7 +43,7 @@ public EncryptedRecord(int grpId, RecordType plainRecType) {
/** {@inheritDoc} */
@Override public RecordType type() {
- return RecordType.ENCRYPTED_RECORD;
+ return RecordType.ENCRYPTED_RECORD_V2;
Review comment:
Hello @xtern,
I think changing already existing WAL records is an error-prone approach.
Today we changed a type; tomorrow we will change/add a field and skip the
corresponding changes in the serializer code.
It is just good practice not to change existing records, IMHO. Anyway, it is
up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
