anton-vinogradov commented on a change in pull request #8211:
URL: https://github.com/apache/ignite/pull/8211#discussion_r507725407



##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -149,18 +179,134 @@ def _perform_node_fail_scenario(self, test_config):
 
             start_load_app(self.test_context, ignite_config=load_config, 
params=params, modules=modules)
 
-        data = simulate_nodes_failure(servers, failed_nodes, survived_node)
+        for node in failed_nodes:
+            self.logger.info(
+                "Simulating failure of node '%s' (order %d) on '%s'" % 
(node_id(node), order(node), node.name))
+
+        data = self._simulate_nodes_failure(servers, 
node_fail_task(ignite_config, test_config), failed_nodes,
+                                            survived_node)
 
         data['Ignite cluster start time (s)'] = start_servers_sec

Review comment:
       I meant that "data['blabla']=val" should be next line to the "val = xxx".
   you may just write 
   data = []
   and then append results to it, not defining 
   data = self._simulate_nodes_failure...
   data['Ignite cluster start time (s)'] = ...
   at the method end.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to