xtern commented on a change in pull request #8242: URL: https://github.com/apache/ignite/pull/8242#discussion_r517926171
########## File path: modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/encryption/CacheGroupEncryptionCommand.java ########## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.commandline.encryption; + +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.logging.Logger; +import org.apache.ignite.IgniteException; +import org.apache.ignite.internal.client.GridClient; +import org.apache.ignite.internal.client.GridClientConfiguration; +import org.apache.ignite.internal.commandline.AbstractCommand; +import org.apache.ignite.internal.commandline.Command; +import org.apache.ignite.internal.commandline.CommandArgIterator; +import org.apache.ignite.internal.commandline.CommandList; +import org.apache.ignite.internal.commandline.CommandLogger; +import org.apache.ignite.internal.util.typedef.F; +import org.apache.ignite.internal.visor.encryption.VisorCacheGroupEncryptionTaskArg; +import org.apache.ignite.internal.visor.encryption.VisorCacheGroupEncryptionTaskResult; +import org.apache.ignite.internal.visor.encryption.VisorEncryptionKeyIdsTask; +import org.apache.ignite.internal.visor.encryption.VisorReencryptionResumeTask; +import org.apache.ignite.internal.visor.encryption.VisorReencryptionStatusTask; +import org.apache.ignite.internal.visor.encryption.VisorReencryptionSuspendTask; + +import static org.apache.ignite.internal.commandline.CommandList.ENCRYPTION; +import static org.apache.ignite.internal.commandline.CommandLogger.DOUBLE_INDENT; +import static org.apache.ignite.internal.commandline.CommandLogger.INDENT; +import static org.apache.ignite.internal.commandline.TaskExecutor.BROADCAST_UUID; +import static org.apache.ignite.internal.commandline.TaskExecutor.executeTaskByNameOnNode; +import static org.apache.ignite.internal.commandline.encryption.EncryptionSubcommands.CACHE_GROUP_KEY_IDS; + +/** + * Base cache group encryption multinode subcommand. + * + * @param <T> Command result type. + * @param <S> Multinode task result. + */ +public abstract class CacheGroupEncryptionCommand<T, S extends VisorCacheGroupEncryptionTaskResult<T>> + extends AbstractCommand<VisorCacheGroupEncryptionTaskArg> { + /** Cache group reencryption task argument. */ + private VisorCacheGroupEncryptionTaskArg taskArg; + + /** {@inheritDoc} */ + @Override public VisorCacheGroupEncryptionTaskArg arg() { + return taskArg; + } + + /** {@inheritDoc} */ + @Override public void parseArguments(CommandArgIterator argIter) { + String grpName = argIter.nextArg("Сache group name is expected."); + + if (argIter.hasNextSubArg()) + throw new IllegalArgumentException("Unexpected command argument: " + argIter.peekNextArg()); + + taskArg = new VisorCacheGroupEncryptionTaskArg(grpName); + } + + /** {@inheritDoc} */ + @Override public Object execute(GridClientConfiguration clientCfg, Logger log) throws Exception { + try (GridClient client = Command.startClient(clientCfg)) { + S res = executeTaskByNameOnNode( + client, + visorTaskName(), + taskArg, + BROADCAST_UUID, + clientCfg + ); + + printResults(res, taskArg.groupName(), log); + + return res; + } + catch (Throwable e) { + log.severe("Failed to perform operation."); + log.severe(CommandLogger.errorMessage(e)); + + throw e; + } + } + + /** + * @param res Response. + * @param grpName Cache group name. + * @param log Logger. + */ + protected void printResults(S res, String grpName, Logger log) { + Map<UUID, IgniteException> exceptions = res.exceptions(); + + for (Map.Entry<UUID, IgniteException> entry : exceptions.entrySet()) { + log.info(INDENT + "Node " + entry.getKey() + ":"); + + log.info(String.format("%sfailed to execute command for the cache group \"%s\": %s.", + DOUBLE_INDENT, grpName, entry.getValue().getMessage())); + } + + Map<UUID, T> results = res.results(); + + for (Map.Entry<UUID, T> entry : results.entrySet()) { + log.info(INDENT + "Node " + entry.getKey() + ":"); + + printNodeResult(entry.getValue(), grpName, log); + } + } + + /** + * @param res Response. + * @param grpName Cache group name. + * @param log Logger. + */ + protected abstract void printNodeResult(T res, String grpName, Logger log); + + /** + * @return Visor task name. + */ + protected abstract String visorTaskName(); + + /** Subcommand to Display re-encryption status of the cache group. */ + protected static class ReencryptionStatus extends + CacheGroupEncryptionCommand<Long, VisorCacheGroupEncryptionTaskResult<Long>> { + /** {@inheritDoc} */ + @Override protected void printNodeResult(Long bytesLeft, String grpName, Logger log) { + if (bytesLeft == -1) + log.info(DOUBLE_INDENT + "re-encryption completed or not required"); + else Review comment: Fixed, thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
