dmagda commented on a change in pull request #8424:
URL: https://github.com/apache/ignite/pull/8424#discussion_r524775114
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -49,10 +49,18 @@ tab:C++[unsupported]
The following table describes some most important properties of
`TcpDiscoverySpi`.
You can find the complete list of properties in the
javadoc:org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi[] javadoc.
+[CAUTION]
+====
+You should assign `IgniteConfiguration.localHost` or
`TcpDiscoverySpi.localAddress`.
Review comment:
Vlad,
Good explanation, crystal clear and straight to the point. I made some
tweaks. Please use this final version below and see if we need to mention
`TcpCommunicationSpi.localAddress` along with `TcpDiscoverySpi.localAddress`
_You should initialize the `IgniteConfiguration.localHost` or
`TcpDiscoverySpi.localAddress` parameter only with those network interfaces
that will be used for inter-node communication. By default, a node binds to and
listens on all available IP addresses of an environment it's running on. It can
prolong node failures detection if some of the node's addresses are not
reachable from other cluster nodes._
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -49,10 +49,18 @@ tab:C++[unsupported]
The following table describes some most important properties of
`TcpDiscoverySpi`.
You can find the complete list of properties in the
javadoc:org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi[] javadoc.
+[CAUTION]
+====
+You should assign `IgniteConfiguration.localHost` or
`TcpDiscoverySpi.localAddress`.
+By default, node obtains all available IP addresses. Several node addresses
can prolong detection of node failure.
+You should not allow node bind to multiple ip addresses until they represent
some real physical connections which can
+give you more reliability.
+====
+
[cols="1,2,1",opts="header"]
|===
|Property | Description| Default Value
-| `localAddress`| Local host IP address used for discovery. | By default, the
node uses the first non-loopback address it finds. If there is no non-loopback
address available, then `java.net.InetAddress.getLocalHost()` is used.
+| `localAddress`| Local host IP address used for discovery. Prevails over
`IgniteConfiguration.localHost`. | By default, all available addresses are
assigned to node. If there is no non-loopback address available, then
`java.net.InetAddress.getLocalHost()` is used.
Review comment:
Please adjust to the following:
_... If set, overrides the `IgniteConfiguration.localHost` setting. | By
default, a node binds to all available network addresses. If there is a
non-loopback address available, then `java.net.InetAddress.getLocalHost()` is
used._
##########
File path: docs/_docs/clustering/network-configuration.adoc
##########
@@ -111,7 +119,7 @@ You can find the list of all properties in the
javadoc:org.apache.ignite.spi.com
[cols="1,2,1",opts="header"]
|===
|Property | Description| Default Value
-| `localAddress` | The local address for the communication SPI to bind to. |
+| `localAddress` | The local address for the communication SPI to bind to.
Prevails over `IgniteConfiguration.localHost`. |
Review comment:
Please update to:
_... If set, overrides `IgniteConfiguration.localHost` setting._
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
