zstan commented on a change in pull request #8456: URL: https://github.com/apache/ignite/pull/8456#discussion_r525338040
########## File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/rule/MergeJoinConverterRule.java ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.calcite.rule; + +import org.apache.calcite.plan.RelOptCluster; +import org.apache.calcite.plan.RelOptPlanner; +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.plan.RelTraitSet; +import org.apache.calcite.rel.PhysicalNode; +import org.apache.calcite.rel.RelCollations; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.JoinInfo; +import org.apache.calcite.rel.logical.LogicalJoin; +import org.apache.calcite.rel.metadata.RelMetadataQuery; +import org.apache.ignite.internal.processors.query.calcite.rel.IgniteConvention; +import org.apache.ignite.internal.processors.query.calcite.rel.IgniteMergeJoin; +import org.apache.ignite.internal.util.typedef.F; + +/** + * Ignite Join converter. + */ +public class MergeJoinConverterRule extends AbstractIgniteConverterRule<LogicalJoin> { + /** */ + public static final RelOptRule INSTANCE = new MergeJoinConverterRule(); + + /** + * Creates a converter. + */ + public MergeJoinConverterRule() { + super(LogicalJoin.class, "MergeJoinConverterRule"); + } + + /** {@inheritDoc} */ + @Override public boolean matches(RelOptRuleCall call) { + LogicalJoin logicalJoin = call.rel(0); + + return !F.isEmpty(logicalJoin.analyzeCondition().pairs()); + } + + /** {@inheritDoc} */ + @Override protected PhysicalNode convert(RelOptPlanner planner, RelMetadataQuery mq, LogicalJoin rel) { + RelOptCluster cluster = rel.getCluster(); + + JoinInfo joinInfo = JoinInfo.of(rel.getLeft(), rel.getRight(), rel.getCondition()); + + RelTraitSet leftInTraits = cluster.traitSetOf(IgniteConvention.INSTANCE) + .replace(RelCollations.of(joinInfo.leftKeys)); + RelTraitSet outTraits = cluster.traitSetOf(IgniteConvention.INSTANCE) + .replace(RelCollations.of(joinInfo.leftKeys)); // preserve collation of the left input Review comment: why do we take only left into account here ? If other cases will be produced by pass through or derive - we need additional tests here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
