Mmuzaf commented on a change in pull request #7984: URL: https://github.com/apache/ignite/pull/7984#discussion_r531034827
########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/defragmentation/TimeTracker.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.persistence.defragmentation; + +import java.util.Arrays; +import org.apache.ignite.internal.util.typedef.internal.U; + +/** */ +public class TimeTracker<Stage extends Enum<Stage>> { Review comment: Thas why any build-in aggregation machinery is a bad idea. For building reports, the raw data must be used. I have no doubts about the necessity of having things for debugging and measuring performance, finding hot spots but let's use more flexible and standard things like - [Tracing](https://issues.apache.org/jira/browse/IGNITE-13060) and/or [Cluster performance profiling tool](https://issues.apache.org/jira/browse/IGNITE-12666) Let's remove this thing from PR and file a new issue to implement it the right and more flexible way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
