ptupitsyn commented on a change in pull request #8483:
URL: https://github.com/apache/ignite/pull/8483#discussion_r533422847
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpClientChannel.java
##########
@@ -543,31 +450,20 @@ else if (addr.getPort() < 1024 || addr.getPort() > 49151)
throw new IllegalArgumentException(error);
}
- /** Create socket. */
- private static Socket createSocket(ClientChannelConfiguration cfg) throws
IOException {
- Socket sock = cfg.getSslMode() == SslMode.REQUIRED ?
- new ClientSslSocketFactory(cfg).create() :
- new Socket(cfg.getAddress().getHostName(),
cfg.getAddress().getPort());
-
- sock.setTcpNoDelay(cfg.isTcpNoDelay());
-
- if (cfg.getTimeout() > 0)
- sock.setSoTimeout(cfg.getTimeout());
-
- if (cfg.getSendBufferSize() > 0)
- sock.setSendBufferSize(cfg.getSendBufferSize());
-
- if (cfg.getReceiveBufferSize() > 0)
- sock.setReceiveBufferSize(cfg.getReceiveBufferSize());
-
- return sock;
- }
-
/** Client handshake. */
private void handshake(ProtocolVersion ver, String user, String pwd,
Map<String, String> userAttrs)
throws ClientConnectionException, ClientAuthenticationException,
ClientProtocolError {
+ ClientRequestFuture fut = new ClientRequestFuture();
+ pendingReqs.put(-1L, fut);
+
handshakeReq(ver, user, pwd, userAttrs);
- handshakeRes(ver, user, pwd, userAttrs);
+
+ try {
+ ByteBuffer res = timeout > 0 ? fut.get(timeout) : fut.get();
+ handshakeRes(res, ver, user, pwd, userAttrs);
+ } catch (IgniteCheckedException e) {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
