dmagda commented on a change in pull request #8532: URL: https://github.com/apache/ignite/pull/8532#discussion_r535561492
########## File path: docs/_docs/code-snippets/k8s/stateful/node-configuration.xml ########## @@ -16,11 +16,17 @@ limitations under the License. --> <beans xmlns="http://www.springframework.org/schema/beans"; - xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://www.springframework.org/schema/beans + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd";> <!-- tag::config-block[] --> + <bean class="org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration" name="k8sCfg"> Review comment: I would put this bean definition into the TcpDiscoveryKubernetesIpFinder bean right away. Simplifies readability. Plus, the KubernetesConnectionConfiguration bean is used only by the TcpDiscoveryKubernetesIpFinder bean; thus it should be fine to put one inside of another right away. Please consider such a change for similar places below. ########## File path: docs/_docs/installation/kubernetes/generic-configuration.adoc ########## @@ -388,6 +388,17 @@ Note that we use the external IP address (LoadBalancer Ingress) of the service. include::{javaFile}[tags=connectThinClient, indent=0] ---- +Thin clients support the partition awareness feature that may speed up operations. Thin clients store a mapping of Ignite nodes to cache partitions and send partition requests directly to the right node. +A client connected to the Kubernetes cluster through Ingress can't build such a map. Instead, to activate the feature, one should start a client within the cluster and configure it with KubernetesConnectionConfiguration. Review comment: A not for Nikita Safonov, who will be reviewing and editing the doc. I would probably put these details on the thin client documentation page. And add a callout to this Kubernetes pages saying that you need to enable a thin-client specific IP finder (providing a reference to the thin client page for mode details). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
