ptupitsyn commented on a change in pull request #8614:
URL: https://github.com/apache/ignite/pull/8614#discussion_r549313829
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/services/PlatformServices.java
##########
@@ -559,7 +561,7 @@ public static void convertArrayArgs(Object[] args, Method
mtd) {
@SuppressWarnings({"unchecked", "rawtypes"})
private static class ServiceProxyHolder extends PlatformAbstractTarget {
/** */
- private final Object proxy;
+ public final Object proxy;
Review comment:
Seems to be unnecessary, please revert
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java
##########
@@ -989,7 +990,9 @@ private static boolean knownMap(Object o) {
* @return Result.
*/
public static Object[] unwrapBinariesInArray(Object[] arr) {
- Object[] res = new Object[arr.length];
+ Class<?> compType = arr.getClass().getComponentType();
Review comment:
What is the use case when `compType` is not `Object`, is it covered with
some test? I thought we are unwrapping binary objects here, so `arr` is either
`Object[]`, or maybe `BinaryObject[]`.
In my understanding, `res[i] = unwrapBinary(arr[i])` line below can return
an instance of any class, so `res` must be an `Object[]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
