ptupitsyn opened a new pull request #8627:
URL: https://github.com/apache/ignite/pull/8627
Replace dictionary+interfaces with a simple switch statement in
`BinarySystemHandlers.TryReadSystemType`:
* Less code
* Simpler
* Faster
Benchmark added: `BinarySystemTypeReadBenchmark`; results on Core i7-9700K,
Ubuntu 20.04, .NET Core 3.1:
*Before*
{code}
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 |
Allocated |
|-------
|---------:|----------:|----------:|-------:|------:|------:|----------:|
| Read | 1.080 us | 0.0030 us | 0.0025 us | 0.0725 | - | - |
456 B |
{code}
*After*
{code}
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated
|
|-------
|---------:|--------:|--------:|-------:|------:|------:|----------:|
| Read | 849.4 ns | 4.44 ns | 4.16 ns | 0.0725 | - | - | 456 B
|
{code}
(~20% improvement)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
