dmagda commented on a change in pull request #8532:
URL: https://github.com/apache/ignite/pull/8532#discussion_r557781530
##########
File path: docs/_docs/installation/kubernetes/generic-configuration.adoc
##########
@@ -388,6 +388,20 @@ Note that we use the external IP address (LoadBalancer
Ingress) of the service.
include::{javaFile}[tags=connectThinClient, indent=0]
----
+== Partition Awareness
+
+include::../../includes/partition-awareness.adoc[]
+
+To enable the partition awareness feature within scaling Kubernetes enviroment
one should start a client within the cluster and configure it with
`KubernetesConnectionConfiguration`.
+In this case, a client can connect to every pod in a cluster.
+
+Note that client configuration must be in sync with Ignite node configuration.
Review comment:
What does this sentence mean? What type of synchronization is assumed?
Confusing.
##########
File path:
examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.examples.client;
+
+import org.apache.ignite.Ignition;
+import org.apache.ignite.client.ClientCache;
+import org.apache.ignite.client.IgniteClient;
+import org.apache.ignite.client.ThinClientKubernetesAddressFinder;
+import org.apache.ignite.configuration.ClientConfiguration;
+import org.apache.ignite.examples.model.Address;
+import
org.apache.ignite.kubernetes.configuration.KubernetesConnectionConfiguration;
+
+/**
+ * Demonstrates how to use Ignite thin client within the Kubernetes cluster
using KubernetesConnectionConfiguration.
Review comment:
@Nikita-tech-writer, please check the comments in the source code files
too. I see some spellings below.
##########
File path: docs/_docs/thin-clients/java-thin-client.adoc
##########
@@ -86,6 +86,16 @@ The following code sample illustrates how to use the
partition awareness feature
include::{sourceCodeFile}[tag=partition-awareness,indent=0]
----
+If list of server nodes is dynamically changing or scaling than it is possible
to configure connection with custom implementation of `ClientAddressFinder`. It
should provide actual server addresses collection for every time client ask it.
+The following code sample illustrates how to use it.
+
+[source, java]
+----
+include::{sourceCodeFile}[tag=client-address-finder,indent=0]
+----
+
+Currently Ignite provides the only implementation of this interface.
`ThinClientKubernetesAddressFinder` is created to handle scalable Kubernetes
environment.
Review comment:
I don't understand what the sentence means. You say "Ignite provides the
only implementation of this interface". What interface is assumed? Why is it
important to mention this only implementation?
Instead, provide a bullet-point list explaining the code snippet. The
snippet has the `fetchServerAddresses` method that is not implemented. It seems
that you are trying to say that "The fetchServerAddress() method shows how an
example implementation might look like if you want clients to retrieve the
server nodes' addresses dynamically. If you are running in a Kubernetes
environment then use the `ThinClientKubernetesAddressFinder` in your thin
client configuration to enable the automatic resolution of the server addresses
on the client side". Nikita please help to adjust the latter if Maxim confirms
that my understanding is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
