sk0x50 commented on a change in pull request #8645:
URL: https://github.com/apache/ignite/pull/8645#discussion_r559429341



##########
File path: 
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/GridDhtPartitionsStateValidator.java
##########
@@ -49,6 +54,13 @@
     /** Cache shared context. */
     private final GridCacheSharedContext<?, ?> cctx;
 
+    /**
+     * Collection of partitions that did not pass validation.
+     * This collection is supported and updated by coordinator node only.
+     * Represents the following mapping: group id -> set of partitions.
+     */
+    private Map<Integer, Set<Integer>> invalidParts = new 
ConcurrentHashMap<>();

Review comment:
       We only write to this collection. I could not find a place where this 
collection was read. So, it does not make sense to me, to use this map at all.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to