ivandasch commented on a change in pull request #2:
URL:
https://github.com/apache/ignite-python-thin-client/pull/2#discussion_r560823973
##########
File path: pyignite/connection/__init__.py
##########
@@ -131,47 +142,186 @@ def __init__(self, prefetch: bytes=b'', **kwargs):
cluster,
:param password: (optional) password to authenticate to Ignite cluster.
"""
+ self.client = client
self.prefetch = prefetch
- self._check_kwargs(kwargs)
- self.timeout = kwargs.pop('timeout', None)
- self.username = kwargs.pop('username', None)
- self.password = kwargs.pop('password', None)
- if all([self.username, self.password, 'use_ssl' not in kwargs]):
- kwargs['use_ssl'] = True
- self.init_kwargs = kwargs
-
- read_response = read_response
- _wrap = wrap
+ self.timeout = timeout
+ self.username = username
+ self.password = password
+ self._check_ssl_params(ssl_params)
+ if all([self.username, self.password, 'use_ssl' not in ssl_params]):
Review comment:
Allocate list here? Realy?
may be just
```
if self.username and self.password and 'use_ssl' not in ssl_params:
ssl_params['use_ssl'] = True
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
