anton-vinogradov commented on a change in pull request #8575:
URL: https://github.com/apache/ignite/pull/8575#discussion_r561992594



##########
File path: modules/ducktests/tests/ignitetest/services/utils/control_utility.py
##########
@@ -248,12 +311,15 @@ def __parse_cluster_state(output):
 
         return ClusterState(state=state, topology_version=topology, 
baseline=baseline)
 
-    def __run(self, cmd):
-        node = random.choice(self.__alives())
+    def __run(self, cmd, node=None):
+        if node is None:
+            node = random.choice(self.__alives())
 
         self.logger.debug(f"Run command {cmd} on node {node.name}")
 
-        raw_output = node.account.ssh_capture(self.__form_cmd(node, cmd), 
allow_fail=True)
+        node_ip = socket.gethostbyname(node.account.hostname)

Review comment:
       >> node.account.externally_routable_ip is hostname
   so, what the difference between "hostname" 
(node.account.externally_routable_ip) and node.account.hostname?

##########
File path: modules/ducktests/tests/ignitetest/services/utils/control_utility.py
##########
@@ -248,12 +311,15 @@ def __parse_cluster_state(output):
 
         return ClusterState(state=state, topology_version=topology, 
baseline=baseline)
 
-    def __run(self, cmd):
-        node = random.choice(self.__alives())
+    def __run(self, cmd, node=None):
+        if node is None:
+            node = random.choice(self.__alives())
 
         self.logger.debug(f"Run command {cmd} on node {node.name}")
 
-        raw_output = node.account.ssh_capture(self.__form_cmd(node, cmd), 
allow_fail=True)
+        node_ip = socket.gethostbyname(node.account.hostname)

Review comment:
       > node.account.externally_routable_ip is hostname
   
   so, what the difference between "hostname" 
(node.account.externally_routable_ip) and node.account.hostname?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to