Mmuzaf commented on a change in pull request #8688:
URL: https://github.com/apache/ignite/pull/8688#discussion_r562717697
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/WalStateManager.java
##########
@@ -304,6 +305,12 @@ public boolean prohibitWALDisabling() {
String.format("Cache WAL mode cannot be changed within lock or
transaction " +
"[cacheNames=%s, walEnabled=%s]", cacheNames, enabled));
Review comment:
```suggestion
// TODO: IGNITE-13976 WAL disable/enable with node restarts results in
mismatching state, data loss
```
##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteCluster.java
##########
@@ -545,6 +551,12 @@
* when all data is persisted to disk.
* <p>
* WAL state can be changed only for persistent caches.
+ * <p>
+ * <b>NOTE:</b>
+ * Currently, this method should only be called on a stable topology when
no nodes are leaving or joining cluster,
+ * and all baseline nodes are present.
+ * Cache may be stuck in inconsistent state due to violation of these
conditions. It is advised to destroy
+ * such cache.
Review comment:
```suggestion
* such cache.
TODO: IGNITE-13976 WAL disable/enable with node restarts results in
mismatching state, data loss
```
##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteCluster.java
##########
@@ -527,6 +527,12 @@
* when all dirty pages are prepared for checkpoint, but not necessarily
flushed to disk.
* <p>
* WAL state can be changed only for persistent caches.
+ * <p>
+ * <b>NOTE:</b>
+ * Currently, this method should only be called on a stable topology when
no nodes are leaving or joining cluster,
+ * and all baseline nodes are present.
+ * Cache may be stuck in inconsistent state due to violation of these
conditions. It is advised to destroy
+ * such cache.
Review comment:
```suggestion
* such cache.
TODO: IGNITE-13976 WAL disable/enable with node restarts results in
mismatching state, data loss
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
