ololo3000 commented on a change in pull request #8682:
URL: https://github.com/apache/ignite/pull/8682#discussion_r562934655
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/tracing/SpanTags.java
##########
@@ -111,6 +111,9 @@
/** Whether parsing of the SQL query was skipped due to the cached result.
*/
public static final String SQL_PARSER_CACHE_HIT = "sql.parser.cache.hit";
+ /** Text of SQL query. */
Review comment:
Let's change JavaDoc to something like this: `Identifier of SQL query.`
##########
File path:
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/IgniteH2Indexing.java
##########
@@ -1036,7 +1038,10 @@ public ResultSet executeSqlQueryWithTimer(
Exception failReason = null;
- try (TraceSurroundings ignored =
MTC.support(ctx.tracing().create(SQL_CMD_QRY_EXECUTE, MTC.span()))) {
+ try (TraceSurroundings ignored =
Review comment:
It seems that it would be better to attach this tag to the root SQL_QRY
span and set its value once during RunningQueryManager#register method
execution. Something like - `run.span().addTag(SpanTags.SQL_QRY_ID, () ->
Long.toString(qryId));`
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
