vkulichenko commented on a change in pull request #31:
URL: https://github.com/apache/ignite-3/pull/31#discussion_r562976998
##########
File path:
modules/cli/src/main/java/org/apache/ignite/cli/InteractiveWrapper.java
##########
@@ -38,8 +38,16 @@
import picocli.CommandLine;
import picocli.shell.jline3.PicocliCommands;
+/**
+ * Interactive shell mode for Ignite CLI.
+ */
public class InteractiveWrapper {
Review comment:
Remove the empty line.
##########
File path:
modules/cli/src/main/java/org/apache/ignite/cli/spec/ConfigCommandSpec.java
##########
@@ -31,53 +34,75 @@
}
)
public class ConfigCommandSpec extends CategorySpec {
+ /**
+ * Command for get Ignite node configurations.
+ */
@CommandLine.Command(name = "get", description = "Gets current Ignite
cluster configuration values.")
public static class GetConfigCommandSpec extends CommandSpec {
+ /** Configuration client for REST node API. */
+ @Inject
+ private ConfigurationClient configurationClient;
- @Inject private ConfigurationClient configurationClient;
-
- @CommandLine.Mixin CfgHostnameOptions cfgHostnameOptions;
+ /** Command option for setting custom node host. */
+ @CommandLine.Mixin
+ CfgHostnameOptions cfgHostnameOptions;
Review comment:
Are these fields supposed to be package-private? Unless this is a
Picocli requirement, they should be private (please fix across all commands if
needed).
##########
File path:
modules/cli/src/main/java/org/apache/ignite/cli/builtins/config/HttpClientFactory.java
##########
@@ -21,9 +21,17 @@
import javax.inject.Singleton;
import io.micronaut.context.annotation.Factory;
+/**
+ * Factory for producing simple HTTP clients.
+ */
@Factory
public class HttpClientFactory {
Review comment:
Remove empty line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
