ivandasch commented on a change in pull request #6:
URL:
https://github.com/apache/ignite-python-thin-client/pull/6#discussion_r568500749
##########
File path: pyignite/datatypes/complex.py
##########
@@ -420,12 +454,18 @@ def build_header(cls):
@classmethod
def to_python(cls, ctype_object, *args, **kwargs):
- return ctype_object.type, super().to_python(
+ typ = getattr(ctype_object, "type", None)
Review comment:
Inconsistent naming, may be it's better to use `tc_type` or 'obj_type'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
