timoninmaxim commented on a change in pull request #8490:
URL: https://github.com/apache/ignite/pull/8490#discussion_r569520969
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/SortedIndexSchema.java
##########
@@ -15,25 +15,40 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.processors.query.h2.database.inlinecolumn;
+package org.apache.ignite.internal.cache.query.index.sorted;
-import org.h2.table.Column;
-import org.h2.value.Value;
-import org.h2.value.ValueStringFixed;
+import org.apache.ignite.internal.processors.cache.persistence.CacheDataRow;
/**
- * Inline index column implementation for inlining strings of fixed length.
+ * Schema for sorted index.
*/
-public class FixedStringInlineIndexColumn extends StringInlineIndexColumn {
+public interface SortedIndexSchema {
/**
- * @param col Column.
+ * Describe all index keys.
*/
- public FixedStringInlineIndexColumn(Column col, boolean
useOptimizedCompare) {
- super(col, Value.STRING_FIXED, useOptimizedCompare, false);
- }
+ public IndexKeyDefinition[] getKeyDefinitions();
Review comment:
Schema and Definition are for different purposes.
- IndexDefinition contains instructions on how to create an index and which
parameters it has.
- Schema is responsible for mapping cache entry on index rows.
So schema isn't just a list of keys. For example, `QueryIndexSchema` relies
on the `GridH2RowDescriptor` object to provide the mapping. IOs and IndexRow
require this mapping, but they actually should not have access to
IndexDefinition.
Maybe just "Schema" is not a correct name for this target?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
