timoninmaxim commented on a change in pull request #8490:
URL: https://github.com/apache/ignite/pull/8490#discussion_r582067210
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/inline/keys/StringInlineIndexKeyType.java
##########
@@ -15,62 +15,42 @@
* limitations under the License.
*/
-package org.apache.ignite.internal.processors.query.h2.database.inlinecolumn;
+package org.apache.ignite.internal.cache.query.index.sorted.inline.keys;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
+import
org.apache.ignite.internal.cache.query.index.sorted.inline.IndexKeyTypes;
import org.apache.ignite.internal.pagemem.PageUtils;
import org.apache.ignite.internal.util.GridUnsafe;
-import org.h2.table.Column;
-import org.h2.value.Value;
-import org.h2.value.ValueString;
+import org.jetbrains.annotations.Nullable;
/**
- * Inline index column implementation for inlining {@link String} values.
+ * Inline index key implementation for inlining {@link String} values.
*/
-public class StringInlineIndexColumn extends AbstractInlineIndexColumn {
+public class StringInlineIndexKeyType extends
NullableInlineIndexKeyType<String> {
/** Default charset. */
protected static final Charset CHARSET = StandardCharsets.UTF_8;
+ // TODO: how to configure it? Looks like ignoreCase may be configured on
moment of Search row creation.
/** Whether respect case or not while comparing. */
private final boolean compareIgnoreCase;
- /** Whether to use optimized comparison or not. */
- private final boolean useOptimizedCompare;
+ // TODO: what is it?
+// /** Whether to use optimized comparison or not. */
+// private final boolean useOptimizedCompare;
Review comment:
Restored previous behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
