ibessonov commented on a change in pull request #56: URL: https://github.com/apache/ignite-3/pull/56#discussion_r582908711
########## File path: modules/configuration/src/main/java/org/apache/ignite/configuration/internal/ConfigurationNode.java ########## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.configuration.internal; + +import java.util.List; +import java.util.NoSuchElementException; +import org.apache.ignite.configuration.ConfigurationChanger; +import org.apache.ignite.configuration.RootKey; +import org.apache.ignite.configuration.internal.util.ConfigurationUtil; +import org.apache.ignite.configuration.internal.util.KeyNotFoundException; +import org.apache.ignite.configuration.tree.TraversableTreeNode; + +/** + * Super class for dynamic configuration tree nodes. Has all common data and value retrieving algorithm in it. + */ +public abstract class ConfigurationNode<VIEW> { + /** Full path to the current node. */ + protected final List<String> keys; + + /** Name of the current node. Same as last element of {@link #keys}. */ + protected final String key; + + /** Root key instance for the current trees root. */ + protected final RootKey<?> rootKey; + + /** Configuration changer instance to get latest value of the root. */ + protected final ConfigurationChanger changer; + + /** + * Cached value of current trees root. Useful to determine whether you have the latest configuration value or not. + */ + private volatile TraversableTreeNode cachedRootNode; + + /** Cached configuration value. Immutable. */ + private VIEW val; + + /** + * Validity flag. Configuration is declared invalid if it's a part of named list configuration and corresponding + * entry is already removed. + */ + private boolean invalid; + + /** + * Constructor. + * + * @param prefix Configuration prefix. + * @param key Configuration key. + * @param rootKey Root key. + * @param changer Configuration changer. + */ + protected ConfigurationNode(List<String> prefix, String key, RootKey<?> rootKey, ConfigurationChanger changer) { + this.keys = ConfigurationUtil.appendKey(prefix, key); + this.key = key; + this.rootKey = rootKey; + this.changer = changer; + } + + /** + * Returns latest value of the configuration or throws exception. + * + * @return Latest configuration value. + * @throws NoSuchElementException If configuration is a part of already deleted named list configuration entry. + */ + protected final VIEW refreshValue() throws NoSuchElementException { + if (invalid) Review comment: I am still not sure that second synchronized is required. Gotta think about it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
