ptupitsyn commented on a change in pull request #8839:
URL: https://github.com/apache/ignite/pull/8839#discussion_r585301353
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/IgniteConfiguration.cs
##########
@@ -1379,6 +1379,15 @@ public string ToXml()
return IgniteConfigurationXmlSerializer.Serialize(this,
"igniteConfiguration");
}
+ /// <summary>
+ /// Returns a <see cref="string" /> that represents this instance.
+ /// </summary>
+ /// <returns>A <see cref="string" /> that represents this
instance.</returns>
+ public override string ToString()
+ {
+ return ToXml();
Review comment:
Same as above
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Event/CacheEntryCreateEvent.cs
##########
@@ -76,5 +77,16 @@ public CacheEntryEventType EventType
{
get { return CacheEntryEventType.Created; }
}
+
+ /// <summary>
+ /// Returns a <see cref="string" /> that represents this instance.
+ /// </summary>
+ /// <returns>A <see cref="string" /> that represents this
instance.</returns>
+ public override string ToString()
+ {
+ return string.Format(CultureInfo.CurrentCulture,
Review comment:
`CurrentCulture` is the default, we can omit it (here and below).
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Cache/Event/CacheEntryCreateEvent.cs
##########
@@ -76,5 +77,16 @@ public CacheEntryEventType EventType
{
get { return CacheEntryEventType.Created; }
}
+
+ /// <summary>
+ /// Returns a <see cref="string" /> that represents this instance.
+ /// </summary>
+ /// <returns>A <see cref="string" /> that represents this
instance.</returns>
+ public override string ToString()
+ {
+ return string.Format(CultureInfo.CurrentCulture,
+ "{0} type Cache Event [Key = {1}, HasValue = {2}, Value = {3},
HasOldValue = {4}, OldValue = {5}]",
Review comment:
Let's follow the established format (e.g. see `AffinityKey`):
`CacheEntryCreateEvent [Key={}, ...]` - note that only the type name goes
outside of square brackets, and properties go inside, without spaces around `=`
(here and below).
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Client/IgniteClientConfiguration.cs
##########
@@ -283,5 +283,14 @@ public static IgniteClientConfiguration FromXml(string xml)
{
return
IgniteConfigurationXmlSerializer.Deserialize<IgniteClientConfiguration>(xml);
}
+
+ /// <summary>
+ /// Returns a <see cref="string" /> that represents this instance.
+ /// </summary>
+ /// <returns>A <see cref="string" /> that represents this
instance.</returns>
+ public override string ToString()
+ {
+ return ToXml();
Review comment:
Let's make it `IgniteClientConfiguration [XML]`
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Events/Events.cs
##########
@@ -385,6 +386,11 @@ public bool IsEnabled(int type)
return DoOutInOp((int) Op.IsEnabled, type) == True;
}
+ public override string ToString()
Review comment:
Missing xmldoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
