Mmuzaf commented on a change in pull request #8767:
URL: https://github.com/apache/ignite/pull/8767#discussion_r591811149
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/IdleVerifyUtility.java
##########
@@ -223,6 +228,66 @@ public static String formatUpdateCountersDiff(IgniteEx ig,
List<Integer> diff) {
return diff;
}
+ /**
+ * @param updCntr Partition update counter prior check.
+ * @param grpId Group id.
+ * @param partId Partition id.
+ * @param grpName Group name.
+ * @param consId Local node consistent id.
+ * @param state Partition state to check.
+ * @param isPrimary {@code true} if partition is primary.
+ * @param partSize Partition size on disk.
+ * @param it Iterator though partition data rows.
+ * @throws IgniteCheckedException If fails.
+ * @return Map of calculated partition.
+ */
+ public static Map<PartitionKeyV2, PartitionHashRecordV2>
calculatePartitionHash(
Review comment:
Agree, looks odd. I've tried to keep all these changes `as is` to
simplify the review, however, it looks like the method signature can by
simplified without huge refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
