vkulichenko commented on a change in pull request #8820:
URL: https://github.com/apache/ignite/pull/8820#discussion_r591984576
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/datastructures/GridCacheSemaphoreImpl.java
##########
@@ -662,6 +667,31 @@ private void initializeSemaphore() throws
IgniteCheckedException {
}
}
+ /** {@inheritDoc} */
+ @Override public <T> IgniteFuture<T> acquireAndExecute(IgniteCallable<T>
callable,
+ int numPermits)
throws Exception {
+ acquire(numPermits);
+
+ T value = callable.call();
Review comment:
The method signature implies that it's asynchronous. The implementation,
however, executes the provided callable synchronously. It should be submitted
to the local public thread pool instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
