korlov42 commented on a change in pull request #8814:
URL: https://github.com/apache/ignite/pull/8814#discussion_r595351749
##########
File path:
modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/dialect/OracleDialect.java
##########
@@ -59,24 +65,24 @@
}
}, "(", " AND ", ")");
- String setCols = mkString(uniqCols, new C1<String, String>() {
+ String valuesCols = mkString(cols, new C1<String, String>() {
Review comment:
these changes seems unrelated, hence it's better to revert them
##########
File path:
modules/core/src/main/java/org/apache/ignite/cache/store/jdbc/dialect/OracleDialect.java
##########
@@ -28,6 +28,12 @@
/** */
private static final long serialVersionUID = 0L;
+ private static final String MERGE_ON = "MERGE INTO %s t USING (SELECT %s
FROM dual) v ON %s";
Review comment:
according to [coding
guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments)
javadoc is mandatory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
