alex-plekhanov commented on a change in pull request #8867:
URL: https://github.com/apache/ignite/pull/8867#discussion_r596067792
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core.Tests/Services/Model.cs
##########
@@ -123,7 +123,7 @@ public override int GetHashCode()
// ReSharper disable once InconsistentNaming
public enum ACL
{
- Allow, Deny
+ ALLOW, DENY
Review comment:
Why it's changed to uppercase here? AFAIK pascal case should be used for
enum values in C#
(https://docs.microsoft.com/en-us/previous-versions/dotnet/netframework-1.1/4x252001(v=vs.71)?redirectedfrom=MSDN).
And for binary protocol enum order is used, so uppercase is not required to
match dotnet and java enums.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
