AMashenkov commented on a change in pull request #59: URL: https://github.com/apache/ignite-3/pull/59#discussion_r598148639
########## File path: modules/raft-client/src/main/java/org/apache/ignite/raft/client/message/impl/RemovePeersRequestImpl.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.raft.client.message.impl; + +import java.util.ArrayList; +import java.util.List; +import org.apache.ignite.raft.client.PeerId; +import org.apache.ignite.raft.client.message.RemovePeersRequest; + +class RemovePeersRequestImpl implements RemovePeersRequest, RemovePeersRequest.Builder { + private String groupId; + + private List<PeerId> peersList = new ArrayList<>(); + + @Override public String getGroupId() { + return groupId; + } + + @Override public List<PeerId> getPeersList() { + return peersList; + } + + @Override public Builder setGroupId(String groupId) { + this.groupId = groupId; + + return this; + } + + @Override public Builder addPeer(PeerId peerId) { + if (!this.peersList.contains(peerId)) Review comment: Is this check really needed? May be Set be more suitable? Also, a similar code in RemoveLearnersRequestImpl doesn't have one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
