ptupitsyn commented on a change in pull request #8870: URL: https://github.com/apache/ignite/pull/8870#discussion_r599318042
########## File path: modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/cache/JmhCacheAsyncListenBenchmark.java ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.benchmarks.jmh.cache; + +import org.apache.ignite.IgniteDataStreamer; +import org.apache.ignite.cache.CacheAtomicityMode; +import org.apache.ignite.cache.CacheWriteSynchronizationMode; +import org.apache.ignite.internal.benchmarks.jmh.runner.JmhIdeBenchmarkRunner; +import org.apache.ignite.internal.benchmarks.model.IntValue; +import org.apache.ignite.lang.IgniteFuture; +import org.apache.ignite.lang.IgniteInClosure; +import org.openjdk.jmh.annotations.Benchmark; +import org.openjdk.jmh.annotations.Mode; + +import java.util.concurrent.ThreadLocalRandom; +import java.util.concurrent.atomic.AtomicBoolean; + +/** + * Cache async listen benchmark. + * Measures {@link IgniteFuture#listen(IgniteInClosure)} performance. + * + * Results on i7-9700K, Ubuntu 20.04.1, JDK 1.8.0_275: + * + * Without ForkJoinPool async continuation executor: + * Benchmark Mode Cnt Score Error Units + * JmhCacheAsyncListenBenchmark.get thrpt 10 82052.664 ± 2891.182 ops/s + * JmhCacheAsyncListenBenchmark.put thrpt 10 77859.584 ± 2071.196 ops/s + * + * With ForkJoinPool async continuation executor: + * Benchmark Mode Cnt Score Error Units + * JmhCacheAsyncListenBenchmark.get thrpt 10 76008.272 ± 1506.928 ops/s + * JmhCacheAsyncListenBenchmark.put thrpt 10 73393.986 ± 1336.420 ops/s + */ +@SuppressWarnings({"unchecked", "rawtypes"}) Review comment: Yes, as expected, because we schedule the listener on another thread instead of executing it directly. This is noted in the IEP and on the dev list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
