timoninmaxim commented on a change in pull request #8911:
URL: https://github.com/apache/ignite/pull/8911#discussion_r599573789
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -703,3 +703,147 @@ This view exposes the contents of the metastorage cache.
|NAME | string | Name
|VALUE | string | String or raw binary (if data could not be deserialized for
some reason) representation of an element
|===
+
+== DS_QUEUES
+
+This view exposes the list of `IgniteQueue`.
+
+[{table_opts}]
+|===
+|Column | Data type | Description
+| ID | UUID | Id
Review comment:
Replace "Id" with "ID" as other tables use capital letters for this term.
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -703,3 +703,147 @@ This view exposes the contents of the metastorage cache.
|NAME | string | Name
|VALUE | string | String or raw binary (if data could not be deserialized for
some reason) representation of an element
|===
+
+== DS_QUEUES
+
+This view exposes the list of `IgniteQueue`.
+
+[{table_opts}]
+|===
+|Column | Data type | Description
+| ID | UUID | Id
Review comment:
Remove the leading space char for every column name. Docs for other
tables do not use it.
##########
File path:
modules/core/src/test/java/org/apache/ignite/internal/metric/SystemViewSelfTest.java
##########
@@ -909,6 +945,648 @@ private void checkScanQueryView(IgniteEx client1,
IgniteEx client2, SystemView<S
assertTrue(found1 && found2);
}
+
+ /** */
+ @Test
+ public void testAtomicSequence() throws Exception {
+ try (IgniteEx g0 = startGrid(0);
+ IgniteEx g1 = startGrid(1)) {
+ IgniteAtomicSequence s1 = g0.atomicSequence("seq-1", 42, true);
+ IgniteAtomicSequence s2 = g0.atomicSequence("seq-2",
+ new
AtomicConfiguration().setBackups(1).setGroupName("my-group"), 43, true);
+
+ s1.batchSize(42);
+
+ SystemView<AtomicSequenceView> seqs0 =
g0.context().systemView().view(SEQUENCES_VIEW);
+ SystemView<AtomicSequenceView> seqs1 =
g1.context().systemView().view(SEQUENCES_VIEW);
+
+ assertEquals(2, seqs0.size());
+ assertEquals(0, seqs1.size());
Review comment:
Is there a reason don't show the items in a view on other node before
explicit touch them ([line
992](https://github.com/apache/ignite/pull/8911/files#diff-7d044bfea10b13a9afea8344c276928ccc1304d31a3bb09d617321446af4ba32R992))?
Looks like a bad UX, also by a reason that the backup value is 1 and the ds
should already exist on g1, doesn't it?
##########
File path: docs/_docs/monitoring-metrics/system-views.adoc
##########
@@ -703,3 +703,147 @@ This view exposes the contents of the metastorage cache.
|NAME | string | Name
|VALUE | string | String or raw binary (if data could not be deserialized for
some reason) representation of an element
|===
+
+== DS_QUEUES
+
+This view exposes the list of `IgniteQueue`.
+
+[{table_opts}]
+|===
+|Column | Data type | Description
+| ID | UUID | Id
+| NAME | string | Data structure name
+| CAPACITY | int | Capacity
+| SIZE | int | Current size
+| BOUNDED | boolean | `True` when queue capacity is bounded
+| COLLOCATED | boolean | `True` when collocated
+| GROUP_NAME | string | Cache group name to store data structure
+| GROUP_ID | int | Cache group id to store data structure
+| REMOVED | boolean | `True` if removed
+|===
+
+== DS_SETS
+
+This view exposes the list of `IgniteSet`.
+
+[{table_opts}]
+|===
+|Column | Data type | Description
+| ID | UUID | Id
+| NAME | string | Data structure name
+| SIZE | int | Current size
+| COLLOCATED | boolean | `True` when collocated
+| GROUP_NAME | string | Cache group name to store data structure
+| GROUP_ID | int | Cache group id to store data structure
+| REMOVED | boolean | `True` if removed
+|===
+
+== DS_ATOMICSEQUENCES
+
+This view exposes the list of `IgniteAtomicSequence`
Review comment:
Here and below - missed dot at the end of line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
