NSAmelchev commented on pull request #8940: URL: https://github.com/apache/ignite/pull/8940#issuecomment-810132393
> > > @NSAmelchev Please see my suggested changes to the PR. > > > Just in case: You can commit them directly in the PR. > > > > > > @Nikita-tech-writer Thank you for the review! I have approved your suggestions. > > Great! I'd like to clarify just one thing: > > The script seems work on Windows, doesn't it? > > If yes, then it's better to have two separate tabs for Unix and Windows (the ones that I suggested). > Otherwise, the foematting should be as follows: > > ## [source,shell] > ## performance-statistics-tool/print-statistics.sh path_to_files No, it doesn't work on Windows. > > > @NSAmelchev Please see my suggested changes to the PR. > > > Just in case: You can commit them directly in the PR. > > > > > > @Nikita-tech-writer Thank you for the review! I have approved your suggestions. > > Great! I'd like to clarify just one thing: > > The script seems to work on Windows, doesn't it? > > If yes, then it's better to have two separate tabs for Unix and Windows (the ones that I suggested). > Otherwise, the formatting should be as follows: > > ``` > [source,shell] > ---- > performance-statistics-tool/print-statistics.sh path_to_files > ---- > ``` @Nikita-tech-writer , No, it doesn't work on Windows. I have fixed tabs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
