nizhikov commented on a change in pull request #8946:
URL: https://github.com/apache/ignite/pull/8946#discussion_r604656643
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/filename/PdsConsistentIdProcessor.java
##########
@@ -122,22 +65,28 @@ public PdsConsistentIdProcessor(final GridKernalContext
ctx) {
* @param consistentId compatibility consistent ID
* @return PDS folder settings compatible with previous versions.
*/
- private PdsFolderSettings compatibleResolve(
+ private PdsFolderSettings<NodeFileLockHolder> compatibleResolve(
@Nullable final File pstStoreBasePath,
@NotNull final Serializable consistentId) {
if (cfg.getConsistentId() != null) {
// compatible mode from configuration is used fot this case, no
locking, no consitent id change
- return new PdsFolderSettings(pstStoreBasePath,
cfg.getConsistentId());
+ return new PdsFolderSettings<>(pstStoreBasePath,
cfg.getConsistentId());
}
- return new PdsFolderSettings(pstStoreBasePath, consistentId);
+ return new PdsFolderSettings<>(pstStoreBasePath, consistentId);
}
/** {@inheritDoc} */
- @Override public PdsFolderSettings resolveFolders() throws
IgniteCheckedException {
+ @Override public PdsFolderSettings<NodeFileLockHolder> resolveFolders()
throws IgniteCheckedException {
if (settings == null) {
- settings = prepareNewSettings();
+ PdsFolderResolver<NodeFileLockHolder> resolver =
+ new PdsFolderResolver<>(cfg, log,
ctx.discovery().consistentId(), this::tryLock);
Review comment:
I think no.
According to javadoc comment I accidently removed it's used intentionally -
```
//here deprecated method is used to get compatible version of consistentId
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
