ololo3000 commented on a change in pull request #8937:
URL: https://github.com/apache/ignite/pull/8937#discussion_r604823925
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/metric/impl/MetricUtils.java
##########
@@ -63,10 +63,11 @@ public static String metricName(String... names) {
* @return Array consist of registry name and metric name.
*/
public static T2<String, String> fromFullName(String name) {
- return new T2<>(
- name.substring(0, name.lastIndexOf(SEPARATOR)),
- name.substring(name.lastIndexOf(SEPARATOR) + 1)
- );
+ int i = name.lastIndexOf(SEPARATOR);
Review comment:
If someone tries to call this method with name that does not include
separator he faces StringIndexOutOfBoundsException. I think that it's better to
add assert here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
