isapego commented on a change in pull request #26:
URL:
https://github.com/apache/ignite-python-thin-client/pull/26#discussion_r604811766
##########
File path: pyignite/aio_cache.py
##########
@@ -109,7 +99,7 @@ async def settings(self) -> Optional[dict]:
:return: dict of cache properties and their values.
"""
if self._settings is None:
- conn = await self.get_best_node()
+ conn = await self.client.get_best_node(self._cache_id)
Review comment:
`self.client.get_best_node(self._cache_id)` part looks like a
boilerplate to me. The original version `self.get_best_node()` looks cleaner.
How about we move this logic to `get_best_node()` method in AioCache class? I
would also lessen number of changes in PR and makes git log easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
