ivandasch commented on a change in pull request #27:
URL:
https://github.com/apache/ignite-python-thin-client/pull/27#discussion_r606218282
##########
File path: pyignite/connection/connection.py
##########
@@ -180,22 +166,22 @@ def connect(self) -> Union[dict, OrderedDict]:
detecting_protocol = False
# choose highest version first
- if self.client.protocol_version is None:
+ if self.client.protocol_context is None:
detecting_protocol = True
- self.client.protocol_version = max(PROTOCOLS)
+ self.client.protocol_context = ProtocolContext(max(PROTOCOLS),
BitmaskFeature.all_supported())
try:
result = self._connect_version()
except HandshakeError as e:
if e.expected_version in PROTOCOLS:
- self.client.protocol_version = e.expected_version
+ self.client.protocol_context.version = e.expected_version
Review comment:
We should discard `protocol_context.features` also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
