Sega76 commented on a change in pull request #8928:
URL: https://github.com/apache/ignite/pull/8928#discussion_r610670104
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PagesWriteSpeedBasedThrottle.java
##########
@@ -228,7 +230,12 @@ public PagesWriteSpeedBasedThrottle(
doPark(throttleParkTimeNs);
}
-
pageMemory.metrics().addThrottlingTime(U.nanosToMillis(System.nanoTime() -
curNanoTime));
+ long duration = System.nanoTime() - curNanoTime;
+
+ pageMemory.metrics().addThrottlingTime(U.nanosToMillis(duration));
+
+ if (pageMemory.performanceStatistics() != null &&
pageMemory.performanceStatistics().enabled())
Review comment:
PerformanceStatisticProcessor on initializing may be null
moved to addThrottlingTime
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PagesWriteThrottle.java
##########
@@ -155,6 +160,9 @@ public PagesWriteThrottle(PageMemoryImpl pageMemory,
LockSupport.parkNanos(throttleParkTimeNs);
pageMemory.metrics().addThrottlingTime(U.currentTimeMillis() -
startTime);
+
+ if (performanceStatsEnabled)
Review comment:
done
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/Checkpointer.java
##########
@@ -983,4 +986,29 @@ public CheckpointProgress currentProgress() {
private boolean isShutdownNow() {
return shutdownNow;
}
+
+ /**
+ * Writes checkpoint performance statistics.
+ *
+ * @param chp Checkpoint.
+ * @param tracker CheckpointMetricsTracker.
+ */
+ private void writeStatistics(Checkpoint chp, CheckpointMetricsTracker
tracker) {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
