sashapolo commented on a change in pull request #84:
URL: https://github.com/apache/ignite-3/pull/84#discussion_r611506175



##########
File path: 
modules/network/src/main/java/org/apache/ignite/network/AbstractMessagingService.java
##########
@@ -15,36 +15,28 @@
  * limitations under the License.
  */
 
-package org.apache.ignite.network.scalecube;
+package org.apache.ignite.network;
 
-import org.apache.ignite.network.message.NetworkMessage;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 /**
- * Test response.
+ * Base class for {@link MessagingService} implementations.
  */
-public class TestResponse implements NetworkMessage {
-    /** Public type for tests. */
-    public static final short TYPE = 2;
+public abstract class AbstractMessagingService implements MessagingService {
+    /** */
+    private final Collection<NetworkMessageHandler> messageHandlers = new 
CopyOnWriteArrayList<>();
 
-    /**
-     * Some response test value.
-     */
-    private final int responseNumber;
-
-    /** Constructor. */
-    public TestResponse(int responseNumber) {
-        this.responseNumber = responseNumber;
+    /** {@inheritDoc} */
+    @Override public void addMessageHandler(NetworkMessageHandler handler) {

Review comment:
       https://issues.apache.org/jira/browse/IGNITE-14519




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to