SammyVimes commented on a change in pull request #92:
URL: https://github.com/apache/ignite-3/pull/92#discussion_r612413185
##########
File path:
modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeClusterServiceFactory.java
##########
@@ -41,41 +41,51 @@
var cluster = new ClusterImpl()
.handler(cl -> new ClusterMessageHandler() {
+ /** {@inheritDoc} */
@Override public void onMessage(Message message) {
messagingService.fireEvent(message);
}
+ /** {@inheritDoc} */
@Override public void onMembershipEvent(MembershipEvent event)
{
- topologyService.fireEvent(event);
+ topologyService.onMembershipEvent(event);
}
})
.config(opts -> opts.memberAlias(context.getName()))
.transport(opts -> opts.port(context.getPort()))
.membership(opts ->
opts.seedMembers(parseAddresses(context.getMemberAddresses())));
// resolve cyclic dependencies
- topologyService.setCluster(cluster);
messagingService.setCluster(cluster);
return new AbstractClusterService(context, topologyService,
messagingService) {
+ /** {@inheritDoc} */
@Override public void start() {
cluster.startAwait();
+
+ topologyService.setLocalMember(cluster.member());
Review comment:
Cluster is not started hence there is no local member at the moment of
the creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
